Spacing presets: fix/minor issues noted in initial UI PR #43214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pacing presets available
glendaviesnz
added
the
Global Styles
18 tasks
|
Size Change: +64 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
andrewserong
added
the
[Type] Bug
andrewserong
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Thanks for following up @glendaviesnz!
✅ The custom value toggle is now square
✅ When spacing sizes are empty, the BoxControl is now used in global styles
✅ The right alignment of the Unlink button is now restored
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
Because we like to tidy up after ourselves 😄
How?
Various ways and means
Testing Instructions
theme.jsonchange thesettings.spacing.spacingScale.stepsvalue to 0 then check that in the global styles dimensions panel the BlockControl component displays instead of the spacing presets oneScreenshots