Merged
Conversation
|
Size Change: -45 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
12 tasks
t-hamano
reviewed
Aug 2, 2022
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for your great work!
✅ I have tried changing the global CSS switcher added in #42747 on Storybook, and I have confirmed the widths and heights are maintained correctly on each component.
✅ The issue reported in #41961 (box-sizing not applied to input elements in table block placeholders) has been fixed.
I think that the following box-sizing could also be removed in the BaseControl-based component.
I tried turning box-sizing on and off in the developer tools, but the layout was maintained correctly on the Storybook.
ciampo
approved these changes
Aug 2, 2022
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Code changes LGTM 🚀
Components tested:
-
CheckboxControl -
ComboboxControl -
FocalPointPicker -
RadioControl -
RangeControl -
SearchControl -
SelectControl -
TextControl(fixes width bug) -
TextareaControl(fixes width bug) -
ToggleControl -
ToggleGroupControl(fixes height bug) -
ToolsPanel
Member
Author
Ah sorry, I totally forgot to mention these! 🤦 I left these two intentionally, because they apply to specific tag types (select, img, video) instead of div/span. It is possible that wp-components are used in a CSS environment where there are broadly scoped CSS files similar to |
Contributor
Thank you for the detailed explanation. |
t-hamano
approved these changes
Aug 3, 2022
bph
added
the
Needs Dev Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #42415
Part of #41961
What?
box-sizingreset to BaseControl. This immediately fixes the box-sizing problems we were seeing in the following components:box-sizingdeclarations in components based on BaseControl.Why?
We can't guarantee that the surrounding context has a box-sizing reset in place.
Testing Instructions
npm run storybook:dev<BaseControlto see where it's used in the repo, especially in packages other than wp-components. Take a look at the code (or test in wp-env!) to see if there could be problems.✅ I have visually inspected all the BaseControl-based components compared with
trunkto check for regressions