SelectControl: Add flag for larger default size#42456
Merged
Conversation
This was referenced Jul 15, 2022
ciampo
added
[Type] Enhancement
ciampo
approved these changes
Jul 15, 2022
| }; | ||
| } | ||
|
|
||
| const style = sizes[ selectSize ] || sizes.default; |
Contributor
There was a problem hiding this comment.
In which situation is sizes[ selectSize ] returning undefined, so that we have to fallback to the default? (same applies to the similar code change in the sizePaddings mixin)
Member
Author
There was a problem hiding this comment.
Just a courtesy fallback in case a consumer passes an invalid size string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #39397
In preparation for #41973
What?
Adds the
__next36pxDefaultSizeprop to SelectControl for the larger default size.Why?
The #39397 project is on hold, but this one is necessary for implementing size variants for CustomSelectControl (#42460). Basically, I want both SelectControl and CustomSelectControl to share the underlying styling components, and CustomSelectControl already has a
__next36pxDefaultSizeflag. So we need to implement the flag on SelectControl for parity.Testing Instructions
npm run storybook:devand see the SelectControl story.__next36pxDefaultSizeshould only affect thedefaultsize. Other size variants should be unaffected.