Group: Check variation is registered before displaying it in the toolbar#41305
Merged
Group: Check variation is registered before displaying it in the toolbar#41305
Conversation
Mamaduka
added
[Type] Bug
|
Size Change: +48 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/group-toolbar-variations
branch
from
259091f to
c067697
Compare
andrewserong
approved these changes
May 26, 2022
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for fixing this up @Mamaduka, the code change looks good, and it tests nicely:
| Before | After |
|---|---|
 |
 |
LGTM! ✨
Member
Author
|
Thanks for the review, @andrewserong! |
youknowriad
pushed a commit
that referenced
this pull request
May 26, 2022
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #41192.
PR updates
BlockGroupToolbarto only display Row/Stack variation buttons if they're registered.Why?
When variations aren't registered, we shouldn't transform blocks into them.
Testing Instructions
Screenshots or screencast
CleanShot.2022-05-25.at.12.57.37.mp4