Skip to content

Block support docs: update blockGap notes#41225

Merged
ramonjd merged 4 commits intotrunkfrom
docs/block-supports-block-gap
May 26, 2022
Merged

Block support docs: update blockGap notes#41225
ramonjd merged 4 commits intotrunkfrom
docs/block-supports-block-gap

Conversation

@ramonjd
Copy link
Member

@ramonjd ramonjd commented May 23, 2022

What?

Update block support docs to reflect the curiosities of block gap.

Why?

In response to an API update: #41098

How?

Keyboard

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for updating the docs @ramonjd, this reads well to me!

I was wondering if it'd be worth us also stabilising the __experimentalDefault prop at the same time (switch it over to default) based on this comment in the other PR: #41098 (review). What do you think? Worth stabilising, or is it still a little up in the air, given we're doing lots of layout exploration at the moment?

(From my perspective, we're exploring changing lots of things, but being able to set a default fallback value at the block level in block.json probably isn't one of the main areas we're looking at changing up... 🤔)

@ramonjd
Copy link
Member Author

ramonjd commented May 23, 2022

I was wondering if it'd be worth us also stabilising the __experimentalDefault prop at the same time (switch it over to default) based on this comment in the other PR: #41098 (review). What do you think? Worth stabilising, or is it still a little up in the air, given we're doing lots of layout exploration at the moment

Oh definitely, good point!

I wasn't sure, and to be honest, probably just focussed on the "let's document this" part 🤣

I did notice we had nothing about blockGap so I can get rid of the text describing the __experimentalDefault feature for now. It'll stay in the commit history for later use 😄

@andrewserong
Copy link
Contributor

I did notice we had nothing about blockGap so I can get rid of the text describing the __experimentalDefault feature for now. It'll stay in the commit history for later use 😄

Sorry for the late reply, I missed the notification! Yes, sounds good to remove the __experimentalDefault feature for now, and we can add back in the docs when we look at stabilising it to default 🙂

Removed reference to __experimentalDefault
@ramonjd ramonjd self-assigned this May 26, 2022
@ramonjd ramonjd added the [Type] Developer Documentation Documentation for developers label May 26, 2022
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read well to me, thanks for the improvement here!

@ramonjd ramonjd merged commit b3ee249 into trunk May 26, 2022
@ramonjd ramonjd deleted the docs/block-supports-block-gap branch May 26, 2022 03:14
@github-actions github-actions bot added this to the Gutenberg 13.4 milestone May 26, 2022
youknowriad pushed a commit that referenced this pull request May 26, 2022
* Iiitial commit

* Updated to include __experimentalDefault

* Cleaned up code examples
Removed reference to __experimentalDefault

* Update docs/reference-guides/block-api/block-supports.md

Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>

Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants