Template Editor: Use the label 'Clear customizations' when changes are revertable#40935
Merged
Template Editor: Use the label 'Clear customizations' when changes are revertable#40935
Conversation
Mamaduka
added
[Type] Enhancement
Mamaduka
commented
May 9, 2022
| isDestructive | ||
| isDestructive={ ! isRevertable } | ||
| variant="secondary" | ||
| aria-label={ __( 'Delete template' ) } |
Member
Author
There was a problem hiding this comment.
The component already has a text label, no need to use the aria.
Mamaduka
commented
May 9, 2022
| size="body" | ||
| as="p" | ||
| style={ { marginTop: '12px' } } | ||
| style={ { marginTop: '12px', marginBottom: '12px' } } |
Member
Author
There was a problem hiding this comment.
This fixed "padding" mentioned in the issue :)
|
Size Change: +357 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Contributor
|
Thanks for looking in to this :) Could the button be the same as the one in the Site Editor, IE with the description? I think the description is helpful in this context, otherwise you might think that the "Customisations" refer to unsaved changes to the page itself. |
Member
Author
|
@jameskoster, sure. I will try to do a follow-up (in this PR) later today or tomorrow. |
Mamaduka
force-pushed
the
update/delete-template-label
branch
from
2c714b3 to
30b4e26
Compare
Member
Author
|
Hi, @jameskoster I added the info text and adjusted styles a bit to match the dropdown from the Site Editor. Screenshot
|
Mamaduka
commented
May 11, 2022
packages/edit-post/src/components/header/template-title/style.scss
Outdated
Show resolved
Hide resolved
Contributor
|
Optimistic that it would be a small task I attempted to better align the styles with the site editor. I got there, but it took way more code than I'd have expected. It'd be really nice if both editors just used the same component :D
|
Member
Author
|
Thanks, @jameskoster.
I was thinking the same but considering some of the differences; I think it's okay to keep them separate for now. |
Contributor
Appreciate it's probably something to do separately, but they probably shouldn't be different at all, right? |
jameskoster
approved these changes
May 12, 2022
Member
Author
Delete action is a bit different, and we probably don't want to display the permanent delete action in Site Editor. This can be abstracted, but we also want to avoid early abstractions 😅 |
30 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Resolves #40885.
PR updates the delete button label to "Clear customizations" when changes to a template are revertable (template has theme file). It also makes the button non-destructive for this case.
Testing Instructions
Using TT2
Screenshots or screencast