Merged
Conversation
gziolo
added
Gutenberg Plugin
gziolo
approved these changes
Apr 7, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Looks good. Let's land as soon as CI turns green 👍🏻
Thank you so much 🙇🏻
gziolo
added
the
Backport to WP 6.9 Beta/RC
gziolo
removed
the
Backport to WP 6.9 Beta/RC
Member
|
Changes will get backported to WP core with WordPress/wordpress-develop#2534. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This was added in #39842, but without a unit test, so this PR adds the test.
Why?
All new functions in core need unit tests.
How?
Compare the result of calling the function with a static array.
Testing Instructions
Check the tests pass.