Restore defaultPalette/defaultGradients to only hide UI#39966
Merged
Conversation
ajlende
added
[Type] Bug
8 tasks
ajlende
force-pushed
the
fix/default-palette-generation
branch
2 times, most recently
from
67c0fe9 to
3f65b03
Compare
ajlende
pushed a commit
to ajlende/wordpress-develop
that referenced
this pull request
Apr 7, 2022
oandregal
added a commit
that referenced
this pull request
Apr 7, 2022
Co-authored-by: André <583546+oandregal@users.noreply.github.com>
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Apr 11, 2022
Follow-up for [53129]. This PR backports the remaining `defaultDuotone` option changes added in the Gutenberg plugin. Related PRs: WordPress/gutenberg#38681 and WordPress/gutenberg#39966. Props oandregal, ajlende. See #55505. git-svn-id: https://develop.svn.wordpress.org/trunk@53130 602fd350-edb4-49c9-b593-d223f7449a82
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Apr 11, 2022
Follow-up for [53129]. This PR backports the remaining `defaultDuotone` option changes added in the Gutenberg plugin. Related PRs: WordPress/gutenberg#38681 and WordPress/gutenberg#39966. Props oandregal, ajlende. See #55505. Built from https://develop.svn.wordpress.org/trunk@53130 git-svn-id: https://core.svn.wordpress.org/trunk@52719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 11, 2022
Follow-up for [53129]. This PR backports the remaining `defaultDuotone` option changes added in the Gutenberg plugin. Related PRs: WordPress/gutenberg#38681 and WordPress/gutenberg#39966. Props oandregal, ajlende. See #55505. Built from https://develop.svn.wordpress.org/trunk@53130 git-svn-id: http://core.svn.wordpress.org/trunk@52719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Restore the old behavior of
defaultPaletteanddefaultGradientsprior to #38681 to only disable the UI and not stylesheet generation.Make
defaultDuotoneadded in #38681 behave like the otherdefault*options.Re-opens #38299
Why?
As per discussion in #38681, making the
default*options disable generation has adverse affects on block patterns which expect generated styles to be present.How?
Remove
defaultorigin checks and theuse_default_presetsfromPRESETS_METADATA.Testing Instructions
"defaultDuotone": false,"defaultGradients": false,"defaultPalette": falsein theme.json