theme.json: add title key to i18n schema#39936
Merged
Conversation
themejson: add title key to i18n schematheme.json: add title key to i18n schema
Contributor
|
Something I was wondering, we probably need to wrap the "title" property in |
Member
Author
Yeah, we need to do other things for it to be picked up. I've already started looking into this, but I also want to fast-track the schema update and the corresponding WordPress |
ntsekouras
approved these changes
Mar 31, 2022
youknowriad
approved these changes
Mar 31, 2022
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 31, 2022
This is related to Gutenberg changes in WordPress/gutenberg#39936 that marks the "title" key as translatable field in "theme.json" files. See also #54336. Props oandregal. Built from https://develop.svn.wordpress.org/trunk@53038 git-svn-id: http://core.svn.wordpress.org/trunk@52627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Mar 31, 2022
This is related to Gutenberg changes in WordPress/gutenberg#39936 that marks the "title" key as translatable field in "theme.json" files. See also #54336. Props oandregal. Built from https://develop.svn.wordpress.org/trunk@53038 git-svn-id: https://core.svn.wordpress.org/trunk@52627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39322 and #39715
Related WordPress
trunkPR at WordPress/wordpress-develop#2483What?
This PR adds
titleas a new key to translate from atheme.jsonfile. It's necessary to fix the wp-cli i18n-command tests at wp-cli/i18n-command#306Why?
The
titlekey from a style variation is shown to the user, hence, it needs to be translatable.How?
By adding the key to the i18n schema we allow the i18n-command from the wp-cli to pick it up. See wp-cli/i18n-command#306 Though the wp-cli uses the schema from WordPress
trunkso we also need to port the changes there.Testing Instructions
This PR only prepares the code for the wp-cli to pick up translations, so there's nothing to test other than verifying that it doesn't break anything. This is what I did: