Blocks: Disable Grouping when block removal is locked#39541
Merged
Conversation
Mamaduka
added
[Type] Bug
|
Size Change: +355 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 17, 2022
packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js
Outdated
Show resolved
Hide resolved
youknowriad
approved these changes
Mar 17, 2022
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
* Blocks: Disable Grouping when block removal is locked * Use selector in slot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up for #39183 (comment).
Disables block grouping when removal is locked like we disable transformations.
Why?
Grouping is also a transformation; the editor should apply similar logic here.
How?
The
BlockSettingsMenuControls.Slotnow recievedcanRemoveprops fromBlockSettingsDropdown.Testing Instructions