ColorIndicator: Add ts-nocheck to color indicator#38433
Merged
aaronrobertshaw merged 1 commit intotrunkfrom Feb 3, 2022
Merged
ColorIndicator: Add ts-nocheck to color indicator#38433aaronrobertshaw merged 1 commit intotrunkfrom
aaronrobertshaw merged 1 commit intotrunkfrom
Conversation
aaronrobertshaw
added
the
[Feature] UI Components
7 tasks
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
andrewserong
added
the
[Type] Code Quality
andrewserong
approved these changes
Feb 3, 2022
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
LGTM!
✅ Confirmed there are no typos in the code change
✅ Confirmed color indicator in Storybook just to be sure 😁
8 tasks
Contributor
Author
|
Changelog for this will be added via: #38469 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #37769
Description
This PR adds a
// @ts-nocheckto the color indicator component so it can be used in new typed components such as those under development for border controls without needing to type theColorIndicatoras well.Testing Instructions
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).