Add: Hover and Selected states to the palette editor. #37962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +84 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Thanks, @jorgefilipecosta, this looks good to me! It's a pity that we have this double border, but I imagine it's difficult to fix without modifying the CSS of the entire list, and in any case, it would be more suited for a follow-up issue.
|
javierarce
changed the title
|
Thank you for the review @javierarce I will try to fix the double border as a follow-up. |
jorgefilipecosta
deleted the
add/hoover-and-select-states-to-the-palette-editor
branch
|
@jorgefilipecosta @javierarce This works out of the box for buttons. But it disappears when I change the background color of a button. Also, my color settings don't show separate color settings for the hover state. I assume there needs to be a switch set in the theme.json? What would be the right settings? We probably need to update the documentation. Or am I missing what this PR was about? |
Hi @bph, This PR is about the hoover and selected states for the palette editor component itself: The blue line indicates the selected color did not exist before. This is just a change for the internal components. We don't offer anything to allow users to change hoover and selected states of blocks like buttons yet and this PR is not related to that. I think a good issue to check related to that is #38277. |
|
Yes, @jorgefilipecosta I was obviously on a totally different planet when I tried to tested this. Thanks so much for setting me straight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #37832
Adds the hoover and selected states following the proposed design.
Screenshots