Remove warning for enqueued styles in Editor#37937
Merged
Conversation
Mamaduka
requested review from
ajitbohra,
ellatrix,
nerrad and
ntwb
as code owners
Mamaduka
requested review from
aristath,
jorgefilipecosta,
mcsf and
noisysocks
Mamaduka
added
[Package] Block editor
|
Size Change: -178 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
aristath
added
the
Backport to WP 6.9 Beta/RC
Contributor
|
Can we clarify more what are the exceptions that can't be solved? In other words, if the warning is shown, in what case it can't be solved by the plugin/theme author by changing the loading method of its stylesheet? AFAIK, it's only dynamic styles which is fairly a rare case but maybe I'm missing something? |
Contributor
|
Personally I'm not sure the warning does any harm, I'd like to understand more why you think that. |
Member
|
@youknowriad The warning assumes that the only viable scenarios for adding styles to the editor is one of the following:
If it's styles for a block, then the recommendation is to use the block-API to add the styles. The problem is that this doesn't account for any other scenarios. So if a plugin needs to add a stylesheet to the editor (without that stylesheet being related to a specific block), then there's nothing they can do. Ideally, plugins would also be able to use the |
Contributor
Interesting, Indeed that seems problematic, I thought the function worked for plugins as well and the only limitation was "dynamic stylesheets". It makes sense to give this more time then. Can we create a todo list issue to bring this back as it's an important piece of the puzzle to iframe the post editor. |
Member
Author
|
I'll create a to-do issue. |
Member
|
Makes sense. 👍 In the meantime, for WP5.9, are you OK with merging this one @youknowriad? |
Contributor
|
@aristath yes, let's get this one in. |
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was discussed in yesterday's core editor chat.
I think @aristath summarized it well:
The actual work to fix the issue continues in #37466.
Related Trac ticket: https://core.trac.wordpress.org/ticket/54752
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).