SelectControl: mark the children prop as optional#37872
Merged
Conversation
ciampo
added
[Feature] Component System
ciampo
requested review from
aaronrobertshaw,
ajlende,
andrewserong,
diegohaz,
mirka,
mkaz and
ntsekouras
7 tasks
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
diegohaz
approved these changes
Jan 11, 2022
Member
There was a problem hiding this comment.
This looks good to me.
I just wonder why InputBaseProps requires children in the first place. It doesn't make much sense to me.
Edit: Oh, okay! It looks like InputBase is just a wrapper for an input field. Maybe SelectControl should use InputControlProps instead?
aaronrobertshaw
approved these changes
Jan 12, 2022
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for fixing this one @ciampo 👍
✅ Confirmed the typing errors prior to checking out this PR
✅ Confirmed the error was resolved after applying these changes
✅ Tests pass
Edit: Oh, okay! It looks like InputBase is just a wrapper for an input field. Maybe SelectControl should use InputControlProps instead?
I gave this a quick test and it looks like we need to then omit other props e.g. value, onChange etc. The current use of InputBaseProps appears cleanest to me.
andrewserong
approved these changes
Jan 12, 2022
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thanks @ciampo! Just adding another ✅ while I'm here, too. Confirmed the TS error in color-picker/component.tsx before this PR, and that it's resolved after applying the PR 👍
Contributor
Author
|
Thanks all for the review! Will rebase, solve conflicts, and merge as soon as checks are ✅
I tend to agree with @aaronrobertshaw |
ciampo
force-pushed
the
fix/select-contorl-children-mandatory
branch
from
5e8d598 to
e84fbcb
Compare
ciampo
added
Backport to WP 6.9 Beta/RC
noisysocks
removed
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 17, 2022
* `SelectControl`: mark the `children` prop as optional * Update prop documentation * Rename Storybook example * Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression introduced by #29540, where the
childrenprop of theSelectControlcomponent was introduced and marked as non-optional.This PR sets the
childrenprop as optional in the TypeScript definitions. It also updates the docs and the storybook example (although these changes are minor)How has this been tested?
Without changes from this PR
packages/components/src/color-picker/component.tsxfile in a text editor that supports TypeScript lintingSelectControlcomponent about not definingchildrenWith changes from this PR
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).