Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue template typo #37825

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix issue template typo #37825

merged 1 commit into from
Jan 10, 2022

Conversation

jasmussen
Copy link
Contributor

Description

Followup to #37780, which added a schema checkbox to the GitHub issue template. There were two small typos in the change which mean the checkbox didn't render as a checkbox, and the HTML comment wasn't hidden, see the last row in this screenshot:

Screenshot 2022-01-10 at 14 36 54

This PR fixes the typo so the template should render a checkbox and hide the HTML comment.

How has this been tested?

Not actually sure how to test this.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • [] I've updated related schemas if appropriate. <!-- Reference: https://github.com/WordPress/gutenberg/tree/trunk/schemas ->

@jasmussen jasmussen added the [Type] Developer Documentation Documentation for developers label Jan 10, 2022
@jasmussen jasmussen self-assigned this Jan 10, 2022
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jasmussen jasmussen merged commit e6412b4 into trunk Jan 10, 2022
@jasmussen jasmussen deleted the fix/issue-template branch January 10, 2022 15:22
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants