Add: Copy all content to edit site#37781
Merged
jorgefilipecosta merged 1 commit intotrunkfrom Jan 13, 2022
Merged
Conversation
jorgefilipecosta
added
[Package] Edit Site
|
Size Change: +148 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Contributor
|
@jorgefilipecosta Could you please guide me on how to find this button? I'd like to give it a try for accessibility. Thanks! |
Member
|
gziolo
reviewed
Jan 13, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Code is a bit more complex than on the edit post page. I do have not enough knowledge to validate the internal implementation of getText callback, but the rest looks nearly identical.
packages/edit-site/src/components/header/more-menu/copy-content-menu-item.js
Show resolved
Hide resolved
Member
|
Linter complains about formatting. Otherwise, with the explanation for how |
gziolo
approved these changes
Jan 13, 2022
jorgefilipecosta
force-pushed
the
add/copy-all-content-to-edit-site
branch
from
cd0bcf4 to
eea24a5
Compare
Member
Author
|
Hi @alexstine, this PR was merged, but I'm open to iterating on the a11y. This PR follows what happens edit-post if there is any a11y issue it affects both screens and I will gladly iterate and try to fix it. |
Contributor
|
@jorgefilipecosta Works perfectly on latest trunk. Thanks! |
Member
Author
|
Thank you for the tests @alexstine 👍 |
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #21245.
Bring the Copy all content functionality to the site editor.
How has this been tested?
I verified the "Copy all content" button works well on both templates and template parts.
Screenshots