-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update create block type how to guide for block.json #37674
Conversation
packages/create-block-tutorial-template/templates/$slug.php.mustache
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments with minor things. The changes to the document look great and we should have that applied a long time ago. @mkaz, thank you a lot for spending time bringing it up to date.
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
Thanks @gziolo for the review 👏 I think I addressed all the updates, there was still one question around codetabs and the PHP register function, since that code is the same for both JSX/Plain. See if what I put clarifies it enough. |
Yes, I'm still trying to understand why the PHP entry and |
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
@gziolo Correct, the only difference for the block.json is the editorScript property, since one is in a build directory and the other is not. |
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Co-authored-by: Ryan Welcher <ryan.welcher@automattic.com>
4a4ad67
to
14329a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this is ready to go. Thank you for all iterations applied.
Description
The writing your first block type guide was one of the earliest tutorials for creating blocks. This PR updates the guide to match the recommended usage of block.json that is already in the gutenberg-examples repo.
Also, while updating I noticed the create-block scripts included a link to the guide, when it is probably better to link directly to the reference documentation.
How has this been tested?
Documentation changes, check for:
Types of changes
Updates how to guide for creating block type.
Uses new how to guide template and updates for latest development practices.