Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blank site editor when theme name contains a period #37167

Merged
merged 7 commits into from
Dec 16, 2021
Merged

Fix blank site editor when theme name contains a period #37167

merged 7 commits into from
Dec 16, 2021

Commits on Dec 15, 2021

  1. Add \. as valid character in rest route regex

    @mkaz
    mkaz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    8bf21a1 View commit details
    Browse the repository at this point in the history

  2. Fix regex for stylesheet vs. id

    @mkaz
    mkaz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    311df5d View commit details
    Browse the repository at this point in the history

  3. Add slash to regex to support subdir themes

    @mkaz
    mkaz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    cdb6d9c View commit details
    Browse the repository at this point in the history

  4. Include subdir in regex

    @mkaz
    mkaz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    6836963 View commit details
    Browse the repository at this point in the history

  5. Update regex to match core trac update

    @mkaz
    mkaz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    d6c6f4b View commit details
    Browse the repository at this point in the history

  6. Sync route regex for theme directory characters 

    Sync the updates in core from Trac https://core.trac.wordpress.org/changeset/52376
that support theme directories with special characters. Confirm site
editor loads properly.
    @mkaz
    mkaz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    b90d15b View commit details
    Browse the repository at this point in the history

  7. Update global styles phpunit test from trac ticket. 

    The core ticket added additional fixtures and tests that are not in the
plugin. So those are not being copied over. Just updating the existing
test and adding one for /themes endpoint.
    @mkaz
    mkaz committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    6567fb5 View commit details
    Browse the repository at this point in the history