Avoids polluting Layout functionality with Query Pagination specific requirements.#37113
Closed
matiasbenedetto wants to merge 2 commits intoWordPress:trunkfrom
Closed
Avoids polluting Layout functionality with Query Pagination specific requirements.#37113matiasbenedetto wants to merge 2 commits intoWordPress:trunkfrom
matiasbenedetto wants to merge 2 commits intoWordPress:trunkfrom
Conversation
…requirements. This characteristic was introduced here: WordPress#36681 and currently it is only necesary for the Query Pagination block so we can move the functionality to the block's code to avoid adding extra logic to the Layout block support.
7 tasks
3 tasks
6 tasks
7 tasks
Contributor
|
Thanks for all the effort. Is there any way we can avoid introducing a new classname and naming scheme? In general I feel like we should avoid the |
Contributor
|
I'm closing this as the initial changes were eventually reverted. Thanks for your work here @matiasbenedetto! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This characteristic was introduced here by this recently merged PR #36681 and currently it is only necesary for the Query Pagination.
As @ntsekouras suggested we would need to avoid adding extra logic to the Layout block support. So I made this litte refactor to move the functionality to the block's code.
How has this been tested?
Wordpress 5.8.2Gutenberg latest trunk versionScreenshots
Types of changes
This is just a refactor and no functionality is changed.
Checklist:
*.native.jsfiles for terms that need renaming or removal).