Conversation
adamziel
approved these changes
Nov 25, 2021
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently when seeking fallback Navigation Menus to use as the front-of-site fallback for the block rendering the Nav block looks for opening
<!--tags to fetch the first post that has blocks.However this is vulnerable to error because the post might contain a non-block HTML comment which would then be treated as valid.
Whilst we are protected by the code which filters out the resulting
nullblocks that would be returned by the block parser we can safe guard against this in advance by searching for the full block comment<!-- wp:.I checked and this comment is used by all blocks, even those which aren't core blocks. Here's an example using Kadence blocks:
How has this been tested?
core/page-listblock used to render the default fallback experience.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).