Fix: Color palette is not being stored#36817
Merged
jorgefilipecosta merged 1 commit intotrunkfrom Nov 24, 2021
Merged
Conversation
jorgefilipecosta
added
Backport to WP 6.9 Beta/RC
jorgefilipecosta
requested review from
oandregal and
spacedmonkey
as code owners
jorgefilipecosta
force-pushed
the
fix/color-palettes-are-not-being-stored-correctly
branch
2 times, most recently
from
a5b48f7 to
811b797
Compare
jorgefilipecosta
force-pushed
the
fix/color-palettes-are-not-being-stored-correctly
branch
from
811b797 to
a7fef27
Compare
oandregal
approved these changes
Nov 24, 2021
Member
oandregal
left a comment
oandregal
left a comment
There was a problem hiding this comment.
Haven't been able to test manually, but changes look good.
jorgefilipecosta
deleted the
fix/color-palettes-are-not-being-stored-correctly
branch
7 tasks
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #36748 and #36747 we made a regression and the color palettes are not being stored correctly.
This PR fixes the issue.
How has this been tested?
I verified as a user I could change theme, default, and custom palettes and they are stored after reloading the site editor.