Conversation
Mamaduka
added
[Block] Cover
|
Size Change: +40 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Contributor
|
This fixed the issue for me, but I wonder if instead we should tighten up that effect as it shouldn't be setting that attribute when the block is first added as there is no background at that point to determine if it |
Member
Author
|
Thanks for the review, @glendaviesnz. Unfortunately, conditionally updating attribute inside effect will still create an extra undo level. Since |
Contributor
I thought it didn't in my testing yesterday, but I agree that we would be just duplicating all the dependency checks of the I wonder if this would all be more efficient if the isDark checking and attribute setting was only run as part of an explicit background change action instead of with hooks and effects ... but I think we should worry about that later after fixing the immediate issue with the |
glendaviesnz
approved these changes
Nov 25, 2021
Contributor
glendaviesnz
left a comment
glendaviesnz
left a comment
There was a problem hiding this comment.
This tested well for me and fixed the double undo without affecting any of the other functionality for changing text color based on dark or light backgrounds.
As noted here, it is probably worth a follow up to see if there is a more efficient way of setting the isDark attribute.
Member
Author
|
Thanks, @glendaviesnz.
I think |
4 tasks
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR fixes the Cover block "undo trap" by marking attribute update inside
useEffectas non-persistent.Fixes #36781.
How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).