Conversation
adamziel
added
[Block] Navigation
getdave
approved these changes
Nov 22, 2021
Contributor
getdave
left a comment
getdave
left a comment
There was a problem hiding this comment.
Looks good. This is a good way to soft deprecate the block but also ensure it's not in 5.9.
Could you also raise a follow up Issues to remove the block entirely after a couple of versions of Gutenberg Plugin?
|
Size Change: +32 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
adamziel
added
the
Backport to WP 6.9 Beta/RC
38 tasks
This was referenced Nov 23, 2021
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 23, 2021
* Deprecate navigation areas * Document deprecation notice
youknowriad
reviewed
Nov 23, 2021
| ); | ||
|
|
||
| deprecated( 'wp.blockLibrary.NavigationArea', { | ||
| since: '5.9', |
Contributor
There was a problem hiding this comment.
Has this block ever landed on Core as stable? If not, we should use a Gutenberg version here and specify a plugin: "gutenberg" here as well
Contributor
There was a problem hiding this comment.
Has this block ever landed on Core as stable
Not it's not in a stable release of Core only Gutenberg Plugin. I'll spin up a follow up unless @adamziel gets there first.
Thanks for letting us know.
getdave
added a commit
that referenced
this pull request
Nov 23, 2021
Addresses feedback in #36727 (comment)
7 tasks
getdave
added a commit
that referenced
this pull request
Nov 23, 2021
* Add plugin meta data to deprecation notice Addresses feedback in #36727 (comment) * Update packages/block-library/src/navigation-area/edit.js Co-authored-by: Adam Zielinski <adam@adamziel.com>
Contributor
Contributor
|
Yes I really think we need to hide the block. I guess it's only available for backwards compat so let's hide it. |
Contributor
Author
|
+1 to that, thank you for bringing it up. Here's a PR #37026. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #36524. This PR deprecates navigation areas as @noisysocks suggested.
Test steps
Confirm that all editors load properly, and the navigation block is being saved and rendered as expected.