Site Editor: Validate the postType query argument#36706
Merged
noisysocks merged 1 commit intotrunkfrom Nov 23, 2021
Merged
Conversation
23 tasks
Contributor
|
Do you think it's worth checking that it's one of the post types that the screen is intended for ( |
Member
Author
I think it's okay to not check this as Plus, it's kind of neat? 😂 I could see us one day (ab)using this for reusable blocks or something. |
78ed091 to
86e13c6
Compare
noisysocks
added a commit
that referenced
this pull request
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes https://github.com/WordPress/gutenberg/pull/36379/files#r753949616.
This bails if an invalid post type is provided via the
postTypequery argument when loading the Site Editor's list view.How has this been tested?
postTypeargument in the URL to some gibberish e.g.asdf.Checklist:
*.native.jsfiles for terms that need renaming or removal).