Global Styles: rename core origin key to default for presets#36645
Merged
jorgefilipecosta merged 6 commits intotrunkfrom Nov 19, 2021
Merged
Global Styles: rename core origin key to default for presets#36645jorgefilipecosta merged 6 commits intotrunkfrom
core origin key to default for presets#36645jorgefilipecosta merged 6 commits intotrunkfrom
Conversation
jorgefilipecosta
added
the
Global Styles
jorgefilipecosta
requested review from
TimothyBJacobs,
ellatrix,
oandregal and
spacedmonkey
as code owners
|
Size Change: -1 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.9 Beta/RC
oandregal
changed the title
core origin key to default for presets
youknowriad
reviewed
Nov 19, 2021
| const customGradients = useSetting( 'color.gradients.user' ); | ||
| const themeGradients = useSetting( 'color.gradients.theme' ); | ||
| const defaultGradients = useSetting( 'color.gradients.core' ); | ||
| const defaultGradients = useSetting( 'color.gradients.default' ); |
Contributor
There was a problem hiding this comment.
I guess this one might be a breaking change? Should we provide an alias or maybe it's fine for this one?
Member
Author
There was a problem hiding this comment.
I think it is fine origins were never exposed in the core.
youknowriad
reviewed
Nov 19, 2021
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
I think I still see a couple places to change:
- packages/edit-site/src/components/global-styles/use-global-styles-output.js
- phpunit/class-wp-theme-json-test.php
jorgefilipecosta
force-pushed
the
update/core-to-default-on-origin-keys
branch
from
3f76cd9 to
fb4821e
Compare
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
Member
|
Hey there 👋 I was wondering if there's a way for future changes like these to still support a previous naming? The mobile editor uses a global style endpoint where it gets the colors configuration including |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames core origin key to default.
I verified global styles continue to work as before.