Update navigation sidebar responsiveness#36638
Merged
Conversation
talldan
added
[Type] Enhancement
38 tasks
|
Size Change: +31 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
talldan
added
the
Backport to WP 6.9 Beta/RC
kevin940726
reviewed
Nov 19, 2021
Member
kevin940726
left a comment
kevin940726
left a comment
There was a problem hiding this comment.
I think the <Editor> is also using defaultIsOpen and we will want to change it to isDefaultOpen there too.
jameskoster
reviewed
Nov 19, 2021
Contributor
There was a problem hiding this comment.
It won't re-open when going back from mobile to desktop. I don't know if this bit is quite right, but when testing I felt like the site editor should have the same closing behavior as the listing page.
Yeah I think that might be worth trying. It's worth noting that if you open a panel in the editor (like global styles) and resize down / up, that panel will close on mobile and then re-open on desktop. So there's kind of a precedent for re-opening the W menu in the editor too.
talldan
force-pushed
the
update/responsive-navigation-sidebar
branch
from
8fcf85d to
1fba741
Compare
talldan
force-pushed
the
update/responsive-navigation-sidebar
branch
from
1fba741 to
0bd0fab
Compare
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 23, 2021
* Close and open the nav sidebar in the list page * Remove superflouous prop * Tidy up effect
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the way the navigation sidebar works based on #36597 (comment)
It works like this:
Video
Kapture.2021-11-19.at.16.57.36.mp4
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).