Page List block: fix space before href attribute#36505
Merged
talldan merged 1 commit intoWordPress:trunkfrom Nov 16, 2021
Merged
Page List block: fix space before href attribute#36505talldan merged 1 commit intoWordPress:trunkfrom
href attribute#36505talldan merged 1 commit intoWordPress:trunkfrom
Conversation
talldan
added
[Block] Page List
talldan
approved these changes
Nov 16, 2021
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing!
I think the block PHP files are copied over to core when backporting, so not sure if this requires a separate change, or whether it will automatically propagate over in the next beta release. cc @noisysocks
Member
|
It will happen automatically as it's part of the block PHP. |
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end quote for the
classattribute was touchinghref, and Firefox highlighted the markup as invalid.Note: the typo is already in WordPress 5.9 trunk, so this would need fixing in both places.