Fix: Add ability to opt out of Core color palette V2#36492
Merged
Conversation
…isplaying colors
fabiankaegy
added
[Type] Bug
fabiankaegy
requested review from
ajitbohra,
ellatrix,
oandregal and
spacedmonkey
as code owners
7 tasks
|
Size Change: +18 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Nov 15, 2021
Member
oandregal
left a comment
oandregal
left a comment
There was a problem hiding this comment.
Nice! Thanks for the quick turnaround, Fabian.
oandregal
added
the
Backport to WP 6.9 Beta/RC
|
Will this solve the issue for the huge majority of user with PHP themes, as referenced in #36489 My suspicion is "no" |
Member
|
@fabiankaegy I've prepared #36496 to disable the core palette by default for themes with no |
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 22, 2021
7 tasks
|
This does remove the core palette and gradients from the post editor, but not from the site editor. Is this intentional or a bug? |
Member
|
Hi Andrew, the fix for the site editor landed in #36639 which is part of Gutenberg 12.1. |
Member
|
to anyone wondering, these have been renamed to from "corePalette" and "coreGradients" to defaultPalette" and "defaultGradients" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the ability for themes using
theme.jsonto opt out of showing the "Core" color Palette and Core Gradients.{ "version": 1, "settings": { "color": { "corePalette": false, "coreGradients": false } "blocks": { "core/heading": { "color": { "corePalette": true, "coreGradiens": true } } } } }This is the second iteration of this PR. See #36447 for more details about the initial approach.
Closing #36407
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).