Merged
Conversation
|
Size Change: +736 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
WunderBart
changed the title
WunderBart
force-pushed
the
fix/cover-block-regression
branch
from
dd3bb71 to
ee4aee0
Compare
WunderBart
added
[Block] Cover
Member
|
This works as advertised for me: ✅ When setting background color via the block placeholder, its default opacity is set to 100% Here's how it looks on 11.7.1 And on trunk: And the same post running this branch: It looks like the |
Member
|
Hi, @WunderBart I see block validation errors when testing this branch with the TT2 theme. Screenshot
|
Mamaduka
reviewed
Nov 12, 2021
Contributor
I think this is due to this change |
…ndefaulting the backgroundType attribute
Contributor
|
@WunderBart I pushed a change that adds a check for |
added 2 commits
November 16, 2021 10:08
…tribute defaults and setting in useEffect
Contributor
|
@WunderBart I noticed when trying to sort the fixtures that the removal of the default for |
Member
|
Just retesting this after @glendaviesnz's change in 65b5290 The cover block works as expected. Fixture tests are passing for me, and also pasting in deprecated Cover Block code migrates correctly. Transforming from an Image > Cover Block adds a default dimRatio of Creating a Cover Block with media, i.e., an image or video, sets the dimRatio to With a color background, it sets the dimRatio to |
glendaviesnz
added
the
Backport to WP 6.9 Beta/RC
Member
Author
Oh, this looks much better now, thanks! It does seem to cover all the testing scenarios and we don't need to regenerate the fixtures 💪 @ramonjd thanks for testing! It seems we need another approval to unlock this PR though 🙏 |
Member
Author
|
@glendaviesnz one small issue that I've noticed - the title color is not properly set initially when setting a video as a Cover background. Once the opacity slider is moved, it seems to be detecting and seting the correct value though: Screen.Recording.2021-11-16.at.13.32.34.movShould we leave this PR as is and address this issue in a follow-up PR? Let me know what you think! |
This was referenced Nov 16, 2021
Contributor
@WunderBart lets make this a separate issue - #36549 - it seems related to the third party I will get someone to give us a final review and sign off on this today. |
ramonjd
approved these changes
Nov 16, 2021
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Another test for good measure 👍
This PR satisfies the original motivation, i.e., the same cover block in:
11.7.1
Opacity is applied:
Current trunk
Opacity is not applied:
This branch
Opacity returns!
Tests pass when I run:
npm run fixtures:generate
🎉
andrewserong
added
the
[Type] Bug
andrewserong
pushed a commit
that referenced
this pull request
Nov 17, 2021
* Set default dim to 50% for media and 100% for solids Co-authored-by: Glen Davies <glen.davies@a8c.com>
Contributor
|
This PR was cherry picked into the GB 11.9.1 point release in c51a153 |
Member
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 22, 2021
* Set default dim to 50% for media and 100% for solids Co-authored-by: Glen Davies <glen.davies@a8c.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following Cover block regressions:
Fixes situations where Cover blocks published pre #35065 lost their background dim.
Fixes situations where an Image transformed into Cover gets a 100% opaque overlay by default.
Updated tests:
Updated failing Cover block fixtures(see Cover Block: Fix regressions #36406 (comment))How has this been tested?
The following scenarios for the Cover block should be verified:
git checkout v11.7.1,git checkout trunk,git checkout fix/cover-block-regression,Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).