Fix 404 Link in Docs #3532
Merged
Fix 404 Link in Docs #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
approved these changes
Nov 20, 2017
|
Thank you! |
youknowriad
reviewed
Nov 20, 2017
| @@ -93,7 +93,7 @@ attributes: { | |||
| }, | |||
| ``` | |||
|
|
|||
| * **See: [Attributes](/reference/attributes/).** | |||
There was a problem hiding this comment.
Can't we have something transforming the links automatically during build step when targeting markdown files referenced in the manifest? cc @pento
There was a problem hiding this comment.
I considered also using relative links, e.g. ../reference/attributes
There was a problem hiding this comment.
Relative links are the better option, I think. Less processing is always better. 🙂
There was a problem hiding this comment.
The advantage of the markdown option is that navigating in Github works :).
There was a problem hiding this comment.
The advantage of the markdown option is that navigating in Github works :).
I expect it would have 404'd in GitHub prior to this change as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshots (jpeg or gifs if applicable):
Types of changes
Checklist: