Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract a reusable post title component #3517

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Nov 16, 2017

Related to #2761 (comment)

This PR extracts PostTitle component to the reusable components folder by removing all layout styles from the reusable components.

Notes

  • This also extracts PostPermalnk, BlockSettingsMenu and BlockSwitcher but it's not exposed because it shouldn't be used directly (yet).

  • This also includes a small redesign to the post permalink modal to match the latest block toolbar design

Testing instructions

  • Test that the Post Title works and looks like master.

@youknowriad youknowriad self-assigned this Nov 16, 2017
@jasmussen
Copy link
Contributor

Nice, just testing the title component, everything seems to work as it used to, so in that vein, 👍 👍

I did notice some arrow key weirdness, but there's every chance this is unrelated to this PR, but is indeed present in master. After using arrow keys between title and paragraph at some point the caret starts ending up in the middle of the paragraph block:

arrows

@youknowriad
Copy link
Contributor Author

Just cc @mcsf @iseulde about the arrow navigation error above which is not related to this PR

@youknowriad youknowriad merged commit d6af47f into master Nov 20, 2017
@youknowriad youknowriad deleted the update/extract-post-title branch November 20, 2017 08:55
@tfrommen
Copy link
Member

@youknowriad sorry for digging up this old ticket, but regarding your comment above:

This also extracts PostPermalnk [...] but it's not exposed because it shouldn't be used directly (yet).

when do you think the PostPermalink component can be exposed/exported?

In its current form, see here, I don't see anything that would prevent someone from using it in a custom block (or even sidebar).
I guess, when you worked on the post title component (more than one and a half years ago), that was different...?

I'm asking because there is no way to enhance the PostTitle block (yet?), so to properly replace it, one would most probably want to use the existing PostPermalink component, which is not possible either.

Hope this makes sense. 🙂

@youknowriad
Copy link
Contributor Author

:) To be fair, I'm not certain I can answer the question properly because this component changed a lot since this PR.

I think it probably doesn't harm if we expose it (other than having to maintain it without breaking changes, which is a big question in itself).

@igmoweb
Copy link

igmoweb commented May 31, 2019

@youknowriad I just created a new PR to expose that component here: #15943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants