Remove .has-link-color class upon clearing the link color#34700
Merged
Remove .has-link-color class upon clearing the link color#34700
.has-link-color class upon clearing the link color#34700Conversation
oandregal
requested review from
Mamaduka,
getdave,
getsource,
jorgefilipecosta,
richtabor and
ryelle
oandregal
added
[Feature] Design Tools
|
Size Change: +3 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
ryelle
approved these changes
Sep 9, 2021
Contributor
ryelle
left a comment
ryelle
left a comment
There was a problem hiding this comment.
I also noticed this in testing the other PR, thanks for fixing it :) This does clear the link class & attribute, regardless of other colors on the block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #31524
While looking into #34689 I've realized that the
.has-link-colorclass was not removed upon clearing the link color.The reason for that was that the
style.elements.link.colorattribute was never cleared. This PR clears the link color when it's empty, and the class will be removed too.Test
Make sure the class is added:
.has-link-colorclass.Make sure the class is removed:
.has-link-colorclass anymore.Random tests can include setting & clearing other colors, etc.