Use resolveSelect instead of select in saveEntityRecord#34584
Merged
Conversation
|
Size Change: +14 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
jsnajdr
reviewed
Sep 6, 2021
Member
jsnajdr
left a comment
jsnajdr
left a comment
There was a problem hiding this comment.
In theory, the patch looks good, but e2e tests are failing
adamziel
force-pushed
the
fix/use-resolveselect-instead-of-select-in-saveEntityRecord
branch
from
cacb332 to
174231c
Compare
jsnajdr
approved these changes
Sep 7, 2021
Member
jsnajdr
left a comment
jsnajdr
left a comment
There was a problem hiding this comment.
After rebase the CI checks are green and I already said the code looks good 👍
jsnajdr
deleted the
fix/use-resolveselect-instead-of-select-in-saveEntityRecord
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#33201 introduced a bug in the autosaving path of
saveEntityRecord. ThegetAutosavecall wants to fetch the autosave for the given post and wait until it's fetched. Therefore the call should useresolveSelectinstead ofselect. Kudos to @jsnajdr for catching this in #34501 (comment).Test plan
.. todo .., we could use a new automated test here