-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix menu item padding regression. #34435
Conversation
Size Change: -64 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks for the quick fix @jasmussen, much appreciated!
✅ The Edit/Select tool dropdown no longer has a scrollbar
✅ The media replace dropdown no longer has a scrollbar
✅ The dropdown menu items no longer have a scrollbar
Did a quick search in the codebase for other instances of -$grid-unit-15
but they all appear to be unrelated to the popover content children, so I think this catches them all. LGTM! 🚀
Description
Followup to #34378 (comment).
A change to simplify and unify dropdown menu item padding failed to accommodate further customizations done in other components. This caused a horizontal scrollbar to appear in some popovers. This PR follows up and hopefully catches the remaining issues.
How has this been tested?
Please test dropdown menus and elements that use the popover component across the board, but notably these three:
Screenshots
The issue is fixed in these:
Checklist:
*.native.js
files for terms that need renaming or removal).