Testing Overview: update JS example to use React Testing Library#34423
Merged
Testing Overview: update JS example to use React Testing Library#34423
Conversation
7 tasks
gziolo
added
the
[Type] Automated Testing
diegohaz
reviewed
Aug 31, 2021
diegohaz
reviewed
Aug 31, 2021
diegohaz
reviewed
Aug 31, 2021
diegohaz
reviewed
Aug 31, 2021
diegohaz
reviewed
Aug 31, 2021
diegohaz
reviewed
Aug 31, 2021
Contributor
|
In addition to |
Co-authored-by: Haz <hazdiego@gmail.com>
Co-authored-by: Haz <hazdiego@gmail.com>
gziolo
approved these changes
Sep 1, 2021
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
There are some tiny details to discuss before this lands.
Anyway, overall these changes look great. Thank you very much for bringing so desperately needed refresh to testing overview ❤️
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Contributor
Author
Absolutely! I've added a paragraph about it in @gziolo @sarayourfriend @diegohaz all feedback so far should have been tackled, let me know if there's anything else you'd like to see amended! |
2 tasks
gziolo
reviewed
Sep 1, 2021
gziolo
approved these changes
Sep 1, 2021
Member
|
You can wait for @diegohaz for his feedback because he is more experienced with testing components 😄 |
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As agreed in #33960 (comment), this PR updates the JS section of the
Testing Overviewdocs:toMatchDiffSnapshotfunctionHow has this been tested?
👀
Screenshots
Types of changes
Docs
Checklist:
*.native.jsfiles for terms that need renaming or removal).