Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the docs to WordPress.org #3381

Merged
merged 12 commits into from
Nov 9, 2017
Merged

Move the docs to WordPress.org #3381

merged 12 commits into from
Nov 9, 2017

Conversation

pento
Copy link
Member

@pento pento commented Nov 8, 2017

Docutron was lovely, but it's time to move the docs across to WordPress.org.

The docs will live here: https://wordpress.org/gutenberg/handbook/

WordPress.org will sync the docs from master every 15 minutes (though syncing is currently disabled, until this PR is merged).

@pento pento added [Type] Developer Documentation Documentation for developers [Type] Task Issues or PRs that have been broken down into an individual action to take labels Nov 8, 2017
@pento pento added this to the Beta 1.7 milestone Nov 8, 2017
@codebykat codebykat self-requested a review November 8, 2017 06:11
Copy link
Contributor

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a couple typos, other than that this is looking good. Didn't see any missed references to docutron and everything still builds fine. 👍

parents: [ 'outreach' ],
name: 'meetups',
title: 'Meetups',
markdown: require( './talks.md' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be meetups.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @Soean!

@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #3381 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3381      +/-   ##
==========================================
+ Coverage   31.35%   31.44%   +0.09%     
==========================================
  Files         246      248       +2     
  Lines        6778     7073     +295     
  Branches     1218     1320     +102     
==========================================
+ Hits         2125     2224      +99     
- Misses       3915     4042     +127     
- Partials      738      807      +69
Impacted Files Coverage Δ
blocks/editable/index.js 9.77% <ø> (-1.26%) ⬇️
blocks/api/raw-handling/image-corrector.js 78.78% <0%> (-21.22%) ⬇️
blocks/library/latest-posts/index.js 9.09% <0%> (-0.91%) ⬇️
utils/mediaupload.js 20.83% <0%> (ø) ⬆️
editor/block-settings-menu/index.js 0% <0%> (ø) ⬆️
blocks/library/image/block.js 0% <0%> (ø) ⬆️
utils/blob-cache.js 25% <0%> (ø)
components/navigable-container/index.js 95.16% <0%> (ø)
components/autocomplete/index.js 77.72% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd03222...1057929. Read the comment docs.

@youknowriad
Copy link
Contributor

Sad to see docutron go away. We will never be able to embed components this way. But I understand this is not in the direct scope of Gutenberg.

I think the menu order is not correct. The previous/next links are broken too.

@aduth
Copy link
Member

aduth commented Nov 8, 2017

I think the menu order is not correct.

Might make more sense for manifest.json to be defined as an array vs. an object.

@pento
Copy link
Member Author

pento commented Nov 9, 2017

Might make more sense for manifest.json to be defined as an array vs. an object.

Good idea, I've update the theme and this PR to do exactly that, it gets the menu order from the manifest.json array order.

@pento pento merged commit 4208473 into master Nov 9, 2017
@pento pento deleted the task/move-docs-to-w.org branch November 9, 2017 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants