Box Control: Rename VerticalHorizontalInputControls to AxialInputControls#33016
Merged
andrewserong merged 1 commit intotrunkfrom Jun 30, 2021
Merged
Conversation
andrewserong
added
the
[Type] Code Quality
7 tasks
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
Contributor
Author
|
@ciampo and @sarayourfriend this is not at all an urgent PR, but I've just added you as reviewers in case you get a chance to take a look at this (hopefully fairly simple) rename since you looked at the preceding PR (#32610) 🙂 |
ciampo
approved these changes
Jun 30, 2021
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Code changes LGTM, Storybook stories work well!
Contributor
Author
|
Thanks for the review! 🙇 |
andrewserong
deleted the
update/rename-vertical-horizontal-controls-to-axial
branch
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following on from #32610 and based on a suggestion from @mtias, rename the
VerticalHorizontalInputControlscomponent toAxialInputControls.How has this been tested?
Tested for regressions based on the steps in #32610:
npm run storybook:devnpm run test-unit -- packages/components/src/box-control/test/Screenshots
Renamed component in Storybook:
Types of changes
Non-breaking code quality update.
Checklist:
*.native.jsfiles for terms that need renaming or removal).