deregister TOC block until issues are resolved#29718
Merged
Conversation
|
Size Change: -1.68 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
aristath
requested review from
TimothyBJacobs,
ajitbohra and
spacedmonkey
as code owners
Member
|
Thanks! I agree on the first two being blockers, but I think #29562 could come later. |
Member
Author
Good point, thank you. Edited the description 👍 |
ZebulanStanphill
added
the
[Block] Table of contents (experimental)
ockham
approved these changes
Mar 10, 2021
Contributor
ockham
left a comment
ockham
left a comment
There was a problem hiding this comment.
Thanks Ari! This is coming in handy for the 10.2.0 RC that I'm about to release 😄
ZebulanStanphill
approved these changes
Mar 10, 2021
Member
ZebulanStanphill
left a comment
ZebulanStanphill
left a comment
There was a problem hiding this comment.
I'm already working on a refactor PR, so hopefully we should be able to reintroduce the block in Gutenberg 10.3. 👍
Member
|
Here's the refactor PR: #29739. |
3 tasks
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR temporarily deregisters the TOC block.
It should be added back once these 2 tickets are resolved:
This 3rd issue would improve the experience, but not a blocker:
How has this been tested?
Tested by making sure the TOC block is not available to users.
Types of changes
Commented-out the lines that register the block.
Since this is only temporary, commenting-out seems appropriate.
The e2e fixtures were removed to make the tests pass.
cc @mtias
Checklist: