Social Links: Replace CSS variables with block context approach #29330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In stricter environments kses are stripping out the CSS variable inline style resulting in block validation errors. This changes the approach to pass the colors via block context to the inner blocks to be rendered as normal inline color & background-color styles.
aaronrobertshaw
added
[Type] Bug
|
Size Change: +144 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Feb 25, 2021
|
@noisysocks this fixes #29297 and needs to be ported to 5.7. |
|
Thanks for working on this. So happy we didn't need to revert this cool feature ✨ |
Anytime. Thanks for the help narrowing down the possible courses of action to fix the issue without reverting the feature 👍 |
oandregal
added
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Mar 1, 2021
kses are stripping out the CSS variable inline style for roles without unfiltered_html capabilities. This changes the approach to pass the colors via block context to the inner blocks to be rendered as normal inline color & background-color styles.
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Mar 1, 2021
kses are stripping out the CSS variable inline style for roles without unfiltered_html capabilities. This changes the approach to pass the colors via block context to the inner blocks to be rendered as normal inline color & background-color styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29297
Description
The approach taken in #28084 to provide the ability to set colors on the parent social link block and have these applied to inner blocks involved CSS custom properties. This has resulted in a problem where kses strip out the CSS custom property styles resulting in invalid blocks in the editor.
This PR alters the approach to pass the current icon color values via block context down to the individual social links so they can be applied as simple
colorandbackground-colorinline styles. A deprecation has been included to handle updating the saved content for the main social links block.How has this been tested?
Manually.
Testing Instructions
Screenshots
Types of changes
Bug fix.
Checklist: