Fix reusable block crash when converting a just created reusable block to blocks. #29292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Feature] Synced Patterns
|
Size Change: +2.21 kB (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
It seems this has been a problem since #25859 switched from using |
|
I discovered this is actually really easy to reproduce by editing a created reusable block and trying to convert it back to regular blocks before saving. That made the test case much easier to write. I think this problem will have been made more common by recent changes to reusable blocks. Back when they had a more distinct editing/saved state it would be difficult to do this. The bug reports indicate it probably happened only with particular blocks, but now it could quite easily happen with any block. |
youknowriad
reviewed
Feb 25, 2021
| @@ -297,4 +297,29 @@ describe( 'Reusable blocks', () => { | |||
| expect( content ).toEqual( 'Awesome Paragraph modified' ); | |||
| } ); | |||
| } ); | |||
|
|
|||
| // Check for regressions of https://github.com/WordPress/gutenberg/issues/26421. | |||
| it( 'allows conversion back to blocks when the reusable block has unsaved edits', async () => { | |||
youknowriad
approved these changes
Feb 25, 2021
youknowriad
added
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Mar 1, 2021
…k to blocks. (#29292) * Fix reusable block crash when content is a function * Fix incorrect arg to content function * Add an e2e test
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Mar 1, 2021
…k to blocks. (#29292) * Fix reusable block crash when content is a function * Fix incorrect arg to content function * Add an e2e test
Alexius08
added a commit
to DotCamp/ultimate-blocks-legacy
that referenced
this pull request
Mar 5, 2021
Proper fix already released in WordPress/gutenberg#29292
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26421
Reusable blocks crash on conversion when they have unsaved edits.
This happens because the entity
contentprop is passed to the blocksparsefunction. Usually that's ok, because it'll be a string. But when a reusable block has unsaved edits,contentis a function thatparsedoesn't know how to handle.The content function is created here:
gutenberg/packages/core-data/src/entity-provider.js
Lines 183 to 187 in 60314e8
It looks like this function is called on
saveEntityRecord, but is otherwise stored internally as a function:gutenberg/packages/core-data/src/actions.js
Lines 386 to 394 in 5d3681a
This became an issue in #25859, where reusable blocks were switched over to using the entity system. Before that they did a plain
apiFetchand as far as I can tell always dealt with stringcontent.How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: