Add Items Justification to Social Links#28980
Merged
Conversation
mkaz
added
the
[Block] Social
|
Size Change: +3.9 kB (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
jasmussen
reviewed
Feb 15, 2021
| const className = classNames( size, { | ||
| 'has-icon-color': iconColorValue, | ||
| 'has-icon-background-color': iconBackgroundColorValue, | ||
| [ `items-justified-${ itemsJustification }` ]: itemsJustification, |
Contributor
There was a problem hiding this comment.
Did we discuss the naming of this CSS class? I seem to vaguely recall that we did, but can't recall where we ended. I would've probably preferred something like has-justification-left — but maybe there was already an existing CSS class out in the wild?
jasmussen
requested changes
Feb 15, 2021
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
All looked cool right up until the end (and removing the flex-start seems fine). Before:
After:
However it doesn't work on the frontend: this should be "space between":
It also looks like the flex-start is still output by default on the frontend:
It looks like the items justification CSS is not output on the frontend at all.
I have no idea why, because the code looks right.
Member
Author
|
@jasmussen I added the justification CSS to the common.scss for block-library and it all works as expected. |
6 tasks
This was referenced Aug 10, 2021
1 task
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds justify toolbar controls to Social Links, allows for justifying items in the menu (left, center, right, and space-between). This matches the navigation and buttons features.
@jasmussen - the .wp-social-links class was hard-coded with a
justify-content: flex-start;that I removed to get this to work. I'm not sure if we need it sinceflex-startis the default.How has this been tested?
Screenshots
Types of changes