-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Directory API: Return the block pattern value as content #28799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
TimothyBJacobs
approved these changes
Feb 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In WordPress/pattern-directory@6252fd6 & r10644-meta, the WordPress.org API was updated to also pass back a value called
pattern_content
. This contains the raw block content for the pattern, which Gutenberg can understand as a properly formatted pattern. This PR updates the local API to use this new value forcontent
, and updates the test fixtures with the new API response.How has this been tested?
phpunit via the CI tests on this PR
You can also manually test - verify that the
content
value in the response contains the block delimiters, ex"content": "<!-- wp:group -->\n<div class=\"wp-block-group\"><...
GET /wp-json/__experimental/pattern-directory/patterns
Checklist: