Component System: Add Grid Component #28531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
added
[Package] Components
32 tasks
|
Size Change: -474 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
sarayourfriend
requested changes
Jan 27, 2021
| import { getAlignmentProps } from './grid-utils'; | ||
|
|
||
| /** | ||
| * @param {import('@wp-g2/create-styles').ViewOwnProps<import('./types').Props, 'div'>} props |
There was a problem hiding this comment.
It looks like we're missing the types.ts file that goes along with Grid. We should move that over as well.
There was a problem hiding this comment.
Oo! Thanks for catching this.
I'm unsure how to handle the import of the types.js file 🤔
There was a problem hiding this comment.
Should just be moving it over to the repository in the same directory, just like it lives in G2 itself. Let me know if that doesn't make sense and we can discuss further.
mtias
reviewed
Jan 28, 2021
mtias
approved these changes
Jan 28, 2021
added 5 commits
January 28, 2021 10:40
sarayourfriend
approved these changes
Jan 28, 2021
|
Thanks for the review @saramarcondes + @mtias ! Merging this one :) |
lipemat
added a commit
to lipemat/types-js-boilerplate
that referenced
this pull request
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a new Grid component for the new Component System.
This is a brand new layout primitive component.
@wordpress/componentspreviously didn't have aGridcomponent, so we didn't need to "adapt" it.Note: I adjusted the exports for the new
Viewcomponent.Checklist: