Social Link: Add a class to the anchor element#28494
Merged
Conversation
scruffian
added
the
[Block] Social
|
Size Change: -397 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Member
|
Could you just get at the element using the selector I'm not opposed, just asking for clarification and more so we can think about it for other blocks and pieces we develop, so for example other nav links and markup we are creating, should we include classes at each element or not? |
Contributor
Author
|
In Spearhead we have a rule like this: This targets social links, and because of its specificity it is stronger than But this feels unnecessarily complex, which is why I am proposing this change instead. |
Contributor
|
Thanks for the PR. I'm not personally opposed to this, and the use case seems fine. I would defer to @nosolosw, though — is it correct to do something like And in case it's fine, the only change I'd make is to the classname. We had a bit of a false start with social links, calling the individual social link blocks But the |
Member
Right. Social icons are an interesting use case for link colors, I'd say that's something we'd like to do at some point. The link color is still experimental so we'd have to wrangle support for various kind of themes and wouldn't add it to this block just yet. If this works for you, I don't see anything that prevents us to add support for link color later on. |
Contributor
Author
|
I've updated the class name. This shouldn't have any impact on behaviour, but it should make things easier for us in the future... |
mkaz
approved these changes
Jan 28, 2021
Member
mkaz
left a comment
mkaz
left a comment
There was a problem hiding this comment.
Implementation is straight forward and looks like we have agreement.
👍
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a class to the anchor elements inside Social Links. This will make it easier to target/exclude these elements when styling themes. Some themes target all
aelements, and we add exceptions for specific blocks. This is easier to do when the anchor itself has a class.How has this been tested?
Tested with Spearhead theme running latest Gutenberg.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: