Global Styles: Add border radius controls to global styles sidebar#28346
Closed
aaronrobertshaw wants to merge 2 commits intotrunkfrom
Closed
Global Styles: Add border radius controls to global styles sidebar#28346aaronrobertshaw wants to merge 2 commits intotrunkfrom
aaronrobertshaw wants to merge 2 commits intotrunkfrom
Conversation
aaronrobertshaw
added
[Block] Group
|
Size Change: +145 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
6 tasks
Contributor
|
This worked as advertised for me, except for setting the default radius of 20 for the group block - at what level in the .json file should this setting be added? |
Contributor
Author
|
Thanks for testing this.
It should be added at the top level, i.e. the same as the I've updated the testing instructions and created an example gist. Re-tested this and it works for me. |
glendaviesnz
approved these changes
Jan 29, 2021
Contributor
glendaviesnz
left a comment
glendaviesnz
left a comment
There was a problem hiding this comment.
This all worked as expected for me
Contributor
Author
|
A wider set of border block support features have been added in #30124. This includes a border panel for the Global Styles sidebar. Closing this in favour of that PR as it's absorbed these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds border radius controls to the global styles sidebar.
Note: Border radius support is turned off by default.
How has this been tested?
Manually.
Testing Instructions
global.settings.border.customRadiusinexperimental-default-theme.jsonexperimental-default-theme.jsonand copy into your active theme) adding a border radius style forcore/groupblock context.Screenshots
Types of changes
New Feature
Checklist: