Block Directory: Silently avoid re-installing local blocks #28304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
the
[Feature] Block Directory
|
Size Change: +15 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
StevenDufresne
approved these changes
Jan 19, 2021
packages/block-directory/src/components/downloadable-blocks-list/index.js
Show resolved
Hide resolved
ryelle
force-pushed
the
update/block-directory-local-blocks
branch
from
ebb855f to
d2f6444
Compare
gziolo
reviewed
Jan 23, 2021
packages/block-directory/src/components/downloadable-blocks-list/index.js
Outdated
Show resolved
Hide resolved
ryelle
force-pushed
the
update/block-directory-local-blocks
branch
from
ec0823e to
6efed40
Compare
ryelle
force-pushed
the
update/block-directory-local-blocks
branch
from
6efed40 to
877375d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #24911, Fixes #24560 — it's possible to get block directory results for locally installed blocks if you use slightly different keywords (ex
mapsin place ofmap). If this happens, you can try to "Add Block", but the install process will trigger an error. Instead of trying to re-install an existing block, this PR silently switches to the regular insert block flow, so the block is added to the page.In combination with #28301, this should fix the unreliability described in #24911.
Testing
Screenshots