Code Quality: Restrict usage of direct React imports #28278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/react-eslint-restrict
branch
from
7e6c839
to
724cdda
Compare
|
Thanks for the ping Greg! While we're working on this, lemme remove Tug from the reviewers as he's AFK. |
gziolo
force-pushed
the
update/react-eslint-restrict
branch
from
724cdda
to
4d15f4f
Compare
|
@dratwas, thank you for testing 🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables ESLint rule that will restrict the direct usage of React imports. Instead, it recommends using React API through
@wordpress/elementinstead. It also ensures that we don't import React just for the sake of usage of JSX since it's handled by Babel.As part of this changeset, I also fixed all existing violations in the codebase that is part of the mobile app. It's mostly cosmetical change.
It will also help to catch some future work like observed in #28176.
How has this been tested?
npm run lint-jsdoesn't report any errors with this PR. You can try to import something from React and observer an error.Screenshots
Types of changes
Checklist: