[RNMobile] Make initial value passed to slider always a number #27273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
added
the
Mobile App - i.e. Android or iOS
3 tasks
dratwas
approved these changes
Nov 25, 2020
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
cameronvoell
pushed a commit
that referenced
this pull request
Nov 25, 2020
cameronvoell
added a commit
that referenced
this pull request
Nov 30, 2020
* Release script: Update react-native-editor version to 1.42.0 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Make initial value passed to slider always a number (#27273) * [RNMobile] Refactor native gradient logic (#27307) * Refactor native gradient logic * Make using 'length' conditional in serializing * Move fixing logic directly to serializeGradientPosition * Remove global from regex Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
cameronvoell
added a commit
that referenced
this pull request
Dec 7, 2020
* Release script: Update react-native-editor version to 1.42.0 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Make initial value passed to slider always a number (#27273) * [RNMobile] Refactor native gradient logic (#27307) * Refactor native gradient logic * Make using 'length' conditional in serializing * Move fixing logic directly to serializeGradientPosition * Remove global from regex * Release script: Update react-native-editor version to 1.42.1 * Release script: Update with changes from 'npm run core preios' Co-authored-by: Cameron Voell <cameronvoell@gmail.com> Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The value passed to the
Sliderhas to be number so I wrapped theinitialValueintoNumber()How has this been tested?
ButtonblockBackground ColorGradientCustomize Gradient7. Expect app is not crashing
Screenshots
Types of changes
Bug fix
Checklist: