-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert stan #27196
Merged
Merged
Revert stan #27196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
adamziel,
ajitbohra,
chrisvanpatten,
draganescu,
gziolo,
kevin940726,
mkaz,
nerrad,
noisysocks,
ntwb,
talldan and
tellthemachines
as code owners
November 23, 2020 12:49
youknowriad
added
[Package] Data
/packages/data
[Type] Experimental
Experimental feature or API.
labels
Nov 23, 2020
Size Change: -1.18 kB (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #27140 I discovered some downsides that are intrinsic to the approach and which would require more time to explore and measure the performance impact on central stores like the block-editor. so my thinking right now is that we should land both the refactoring of block-editor and stan at the same time because it's the only way we could validate the performance improvements entirely.