-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Make height conversion test ios only #27195
Conversation
Size Change: -1.15 kB (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
packages/react-native-editor/__device-tests__/gutenberg-editor-cover.test.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me Luke and all test jobs pass (including the extended tests on the gb-mobile PR). I've only left a minor comment to add a line-comment to help folks understand the platform check so, please add one and feel free to merge afterwards. I'll green-light the PR now.
Description
Patch
Cover
e2e test which is failing on Android since different received values.How has this been tested?
CI on gutenberg mobile: wordpress-mobile/gutenberg-mobile#2827
Screenshots
Types of changes
Checklist: